Skip to content

Conversation

longye-tian
Copy link
Contributor

@longye-tian longye-tian commented Aug 7, 2025

reference to issue #237

GitHub Copilot Review Instructions for Subtitle Capitalization Changes

Overview

Review a large-scale change that converts all subtitles (headings marked with ##, ###, ####) in lecture markdown files from title case to sentence case, where only the first letter of the first word should be capitalized.

Note orth_proj.md is not changed on purpose. So you can skipped this one

What to Check

1. Verify Sentence Case Conversion

  • Correct: ## The density case, ### Computing stationary densities, ## A model with restructuring
  • Incorrect: ## The Density Case, ### Computing Stationary Densities, ## A Model with Restructuring

2. Ensure Proper Names Remain Capitalized

Check that the following proper names maintain their capitalization:

  • Economic theorists: Bellman, Nash, Ramsey, Lucas, Markov, Kalman, Von Neumann, Barro, Hall, Friedman, Walras, Arrow, Pareto, Phillips, Euler, Lagrange, Hamilton, Cobb, Douglas, Solow, Swan, Rosen, Topel, Modigliani, Miller, Stackelberg, Ponzi, Ricardian
  • Mathematical/Statistical names: Gaussian, Newton, Bayes, Taylor
  • Example: ## The Ramsey problem ✅ (Ramsey is a proper name)

3. Preserve Technical Terms and Acronyms

Verify these remain fully capitalized:

  • Acronyms: ARMA, BEGS, AMSS, CRRA, LQ, DP, DPs, IID, GARCH, VAR, OLS, MLE, GMM
  • Technical notation: AR(1), MA(1), ARMA(p,q)
  • Programming terms: Python, Jupyter, NumPy, SciPy
  • Example: ### ARMA processes ✅, ## Discrete DPs

4. Special Markdown Syntax Preservation

Ensure MyST markdown index directives are handled correctly:

  • The display text should follow sentence case
  • The index entry can remain as needed
  • Example: ### {index}\Spectral analysis <single: Spectral Analysis>`` ✅
    • Display text "Spectral analysis" is sentence case
    • Index entry "Spectral Analysis" preserved as is

5. Check for Consistency Issues

Look for:

  • Mixed patterns: Some headings fixed, others missed in the same file
  • Over-correction: Words that should remain capitalized but were lowercased
    • Articles at the beginning should be lowercase: ## A dead end
    • But not: ## a dead end
  • Under-correction: Title case patterns that were missed
    • Look for patterns like ## Word Word where the second word isn't a proper name

6. Verify No Code Blocks Were Modified

Ensure changes were NOT made to:

  • Python comments inside code blocks (even if they contain # or ##)
  • Code cell metadata
  • YAML frontmatter
  • Example - this should NOT be changed:
    # This is a Python comment
    ## This is also a Python comment

7. Edge Cases to Verify

  • Compound terms: ## Roll-over risk ✅ (not "Roll-Over Risk")
  • Numbers: ## Model 1 (complete markets)
  • Colons: ## Appendix: algorithms ✅ (word after colon follows same rule)
  • Parenthetical phrases: ## One- and two-period bonds but no restructuring

Specific Patterns to Flag as Issues

  1. Title Case Remnants: Any heading where multiple words are capitalized (unless proper names/acronyms)

    • Flag: ## Public Finance Questions
    • Should be: ## Public finance questions
  2. Over-lowercase: Proper names or acronyms that were incorrectly lowercased

    • Flag: ## The ramsey problem
    • Should be: ## The Ramsey problem
  3. Inconsistent Treatment: Same term treated differently in different places

    • If "Gaussian" is capitalized in one heading but not another
  4. Broken Markdown: Any heading that might have been corrupted during editing

    • Missing spaces, broken MyST syntax, etc.

Files to Pay Special Attention To

Focus extra attention on these files which had many changes:

  • hs_recursive_models.md (42+ subtitle changes)
  • opt_tax_recur.md (26+ subtitle changes)
  • discrete_dp.md (24+ subtitle changes)
  • dyn_stack.md (23+ subtitle changes)
  • Files with MyST index directives: arma.md

Expected Outcome

All 54 lecture markdown files should have:

  • Consistent sentence case for all subtitles
  • Proper preservation of proper names, technical terms, and acronyms
  • No modifications to code blocks or non-heading content
  • Maintained markdown syntax integrity

Review Command Suggestions

# Check for remaining title case issues
grep -r "^##\+ [A-Z][a-z]* [A-Z]" lectures/*.md

# Verify proper names are preserved
grep -r "^##.*[Rr]amsey" lectures/*.md

# Check for over-correction
grep -r "^## [a-z]" lectures/*.md  # Should not start with lowercase

# Verify no code blocks were changed
git diff --word-diff=color lectures/*.md | grep -A2 -B2 "```"

Summary of Changes

  • Total files: 54 lecture markdown files
  • Files modified: 51 files
  • Files unchanged: 3 files (intro.md, markov_jump_lq.md, status.md, zreferences.md)
  • Branch name: fix-lecture-subtitle-capitalization

Quick Validation Checklist

  • All headings use sentence case (only first word capitalized)
  • Proper names remain capitalized
  • Technical acronyms remain uppercase
  • No code blocks were modified
  • MyST syntax is preserved
  • No broken markdown formatting
  • Consistent treatment across all files

Copy link

netlify bot commented Aug 7, 2025

Deploy Preview for lustrous-melomakarona-3ee73e ready!

Name Link
🔨 Latest commit cb26bc6
🔍 Latest deploy log https://app.netlify.com/projects/lustrous-melomakarona-3ee73e/deploys/68abc9453d13720008b22f8f
😎 Deploy Preview https://deploy-preview-240--lustrous-melomakarona-3ee73e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Aug 7, 2025

@github-actions github-actions bot temporarily deployed to pull request August 7, 2025 08:00 Inactive
@longye-tian longye-tian self-assigned this Aug 7, 2025
@longye-tian
Copy link
Contributor Author

longye-tian commented Aug 7, 2025

Hi @mmcky ,

I just finished updating the subtitles in the advanced lecture series using Claude Code and I generate the instructions for github copilot to review all these changes.

But it seems that I cannot ask copilot to do the reviews, i.e., I didn't find copilot in the assignee list.

For orth_proj.md I left the change on purpose to not mix with the other PR. I'll update the orth_proj in the other PR

Best,
Longye

@github-actions github-actions bot temporarily deployed to pull request August 7, 2025 08:42 Inactive
@mmcky mmcky requested a review from Copilot August 7, 2025 08:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements a large-scale conversion of all subtitles in lecture markdown files from title case to sentence case capitalization. The change affects headings marked with ##, ###, and #### across 54 lecture files, where only the first letter of the first word should be capitalized while preserving proper names, technical terms, and acronyms.

Key changes include:

  • Systematic conversion from title case (e.g., "The Density Case") to sentence case (e.g., "The density case")
  • Preservation of proper names like Ramsey, Bellman, Markov, Nash, etc.
  • Preservation of technical acronyms like ARMA, CRRA, LQ, DP, etc.

Reviewed Changes

Copilot reviewed 46 out of 47 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
un_insure.md Updated 8 subtitles to sentence case while preserving "Shavell and Weiss" proper names
troubleshooting.md Converted 2 subtitles including "Fixing your local environment" and "Reporting an issue"
tax_smoothing_3.md Updated 3 subtitles including technical terms like "Roll-over risk"
tax_smoothing_2.md Converted 5 subtitles while preserving proper names and technical terms
tax_smoothing_1.md Updated 3 subtitles including "Public finance questions" and "Barro model"
stationary_densities.md Converted 9 subtitles including technical terms and method names
smoothing_tax.md Updated 6 subtitles preserving technical terms and proper names
smoothing.md Converted 11 subtitles including model specifications and market structure
rosen_schooling_model.md Updated 3 subtitles including framework references
robustness.md Converted 15 subtitles including mathematical and technical concepts

@mmcky mmcky changed the title Lecture Subtitle [styleguide] adjust lecture titles to match the QuantEcon style guide rules around capitalisations. Aug 7, 2025
@@ -170,7 +170,7 @@ By the [Cauchy-Schwartz inequality](https://en.wikipedia.org/wiki/Cauchy%E2%80%9

Evidently, $\gamma(k)$ does not depend on $t$.

### {index}`Wold Representation <single: Wold Representation>`
### {index}`Wold representation <single: Wold Representation>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@longye-tian can you double check if this should be Wald or Wold?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be Wold

@@ -283,7 +283,7 @@ An asset with an $R^i$ that is **low** when consumption growth is **low** has $\



## Mean-Variance Frontier
## Mean-variance frontier
Copy link
Contributor

@mmcky mmcky Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Mean-variance frontier
## Mean-Variance frontier

@jstac for our style guide should hyphenation of the first word be both capitalised?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-capitalized looks a bit better to me.

@@ -716,7 +716,7 @@ Thus, in our context, time-variation of $\vec \mu$ chosen by a Ramsey planner
is the telltale sign of the Ramsey plan's **time inconsistency**.


## Constrained-to-Constant-Growth-Rate Ramsey Plan
## Constrained-to-constant-growth-rate Ramsey plan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Constrained-to-constant-growth-rate Ramsey plan
## Constrained to constant growth rate Ramsey plan

Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@longye-tian thanks for putting this PR together -- just some very minor questions. Then we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants